-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show taxable payment amounts in tax report #392
Merged
ezewer
merged 20 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/show-taxable-payment-amounts-in-tax-report
Jul 10, 2024
Merged
Show taxable payment amounts in tax report #392
ezewer
merged 20 commits into
bitfinexcom:staging
from
ZIMkaRU:feature/show-taxable-payment-amounts-in-tax-report
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezewer
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
1 task
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to show taxable payment amounts in the tax report.
The idea is to show the amounts of
_isMarginFundingPayment
,_isAffiliateRebate
,_isStakingPayments
,_isAirdropOnWallet
in the tax report essentially as it is, because it's the user's proceedsIn the tax report, we should show these sorts of entries with fields:
Currency
Amount
Date Acquired
Date Sold
- must be emptyProceeds
Cost
- must be emptyGain or Loss
- equal toProceeds
Additionally, adds
type
field to the tax report response for easier debugging purposes, and the field should be one from the following list:AIRDROP_ON_WALLET
MARGIN_FUNDING_PAYMENT
AFFILIATE_REBATE
STAKING_PAYMENT
EXCHANGE